Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 E131, E211, E251, E271, E701 #4365

Merged
merged 4 commits into from Feb 23, 2020
Merged

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Feb 22, 2020

This fixes the next flake8 rules:

  • E131: Continuation line unaligned for hanging indent --> 1 affected file
  • E211: Whitespace before '(' --> 1 affected file
  • E251: Unexpected spaces around keyword / parameter equals --> 2 affected files
  • E271: Multiple spaces after keyword --> 1 affected file
  • E701: Multiple statements on one line (colon) --> 5 affected files

@codecov
Copy link

@codecov codecov bot commented Feb 22, 2020

Codecov Report

Merging #4365 into master will decrease coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4365      +/-   ##
==========================================
- Coverage    84.1%   83.87%   -0.23%     
==========================================
  Files         166      166              
  Lines        9910     9912       +2     
  Branches     1471     1473       +2     
==========================================
- Hits         8335     8314      -21     
- Misses       1321     1341      +20     
- Partials      254      257       +3
Impacted Files Coverage Δ
scrapy/utils/iterators.py 97.7% <100%> (+0.05%) ⬆️
scrapy/robotstxt.py 75.3% <0%> (-22.23%) ⬇️
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️
scrapy/utils/defer.py 93.47% <0%> (-2.18%) ⬇️
scrapy/utils/misc.py 95.19% <0%> (-1.93%) ⬇️

wRAR
wRAR approved these changes Feb 22, 2020
@kmike kmike merged commit 4948022 into scrapy:master Feb 23, 2020
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Feb 23, 2020

Thanks @noviluni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants