Make BaseItemExporter’s dont_fail parameter keyword-only #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4370 +/- ##
==========================================
- Coverage 84.14% 83.99% -0.16%
==========================================
Files 166 166
Lines 9965 9965
Branches 1481 1481
==========================================
- Hits 8385 8370 -15
- Misses 1323 1340 +17
+ Partials 257 255 -2
|
|
Thanks @Gallaecio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Make the new
dont_failparameter ofBaseItemExporterkeyword only.Otherwise, we are adding an non-intuitive positional parameter to a class that used to require keyword parameters only.
dont_failwas introduced after 1.8, so it would be great to have this change in for 2.0, otherwise we will need to introduce this change with a deprecation message for positional argument usages.Split out from #4329