Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kmike noticed that autodoc was not working, any API documentation extracted from comments was missing in
master
.This started happening when we removed Scrapy dependencies from
docs/requirements.txt
. The build log issued warnings, but Read The Docs was not configured to fail the build in case of warnings. Travis CI would have failed, weren’t it because Tox automatically installs Scrapy fromsetup.py
, which ReadTheDocs does not.These changes add the dependencies back to the file, and make warnings cause build failures in ReadTheDocs.
You can see it working at https://scrapy-gallaecio.readthedocs.io/en/fix-readthedocs/topics/request-response.html
I also tried just enabling to fail on warning, and indeed the ReadTheDocs build failed after that.