Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up deprecated settings list #4378

Merged
merged 1 commit into from Feb 27, 2020

Conversation

HEndo12345
Copy link
Contributor

@HEndo12345 HEndo12345 commented Feb 26, 2020

  • removed 'SELECTORS_BACKEND' as 'SCRAPY_SELECTORS_BACKEND' is no longer present in this module

  • removed one of 'AUTOTHROTTLE_MAX_CONCURRENCY' as it was duplicated.

(edit) fixes #4376

@codecov
Copy link

@codecov codecov bot commented Feb 26, 2020

Codecov Report

Merging #4378 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
- Coverage   84.14%   84.12%   -0.03%     
==========================================
  Files         166      166              
  Lines        9967     9967              
  Branches     1482     1482              
==========================================
- Hits         8387     8385       -2     
- Misses       1324     1325       +1     
- Partials      256      257       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 89.39% <0.00%> (-1.52%) ⬇️

wRAR
wRAR approved these changes Feb 26, 2020
@HEndo12345
Copy link
Contributor Author

@HEndo12345 HEndo12345 commented Feb 26, 2020

@Gallaecio Gallaecio merged commit 6109ad9 into scrapy:master Feb 27, 2020
2 checks passed
@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 27, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants