Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop horribly outdated deb package build files #4384

Merged
merged 1 commit into from Mar 4, 2020
Merged

Conversation

nyov
Copy link
Contributor

@nyov nyov commented Feb 28, 2020

Debian packaging team might find this helpful.

cheers, @wRAR

wRAR
wRAR approved these changes Feb 28, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 28, 2020

Codecov Report

Merging #4384 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4384      +/-   ##
==========================================
- Coverage   84.16%   84.15%   -0.02%     
==========================================
  Files         166      166              
  Lines        9970     9970              
  Branches     1483     1483              
==========================================
- Hits         8391     8390       -1     
  Misses       1324     1324              
- Partials      255      256       +1     
Impacted Files Coverage Δ
scrapy/utils/trackref.py 82.85% <0.00%> (-2.86%) ⬇️

Copy link
Member

@Gallaecio Gallaecio left a comment

I’m approving this as I see both of you, @nyov and @wRAR, have contributed to the Debian source repository for Scrapy.

I am a bit fearful that removing the folder may cause a removal in their repository when merging, but I guess that will be easy to detect and handle, and long-term it should avoid silly conflicts because they’ve continued work on the debian/ folder in their Debian-specific fork.

I’ll let @wRAR or someone else merge, though 🙂

@nyov
Copy link
Contributor Author

@nyov nyov commented Feb 28, 2020

Debian has it's own debian/ folder, which isn't based on this one. This here stems from scrapinghub's buildbot builds (and later was kept probably more for personal builds). Seeing how outdated it is, I don't think scrapinghub can still be building packages from it, though.

@nyov nyov force-pushed the nodeb branch 2 times, most recently from 253af0f to 3e1184f Compare Feb 28, 2020
@kmike
Copy link
Member

@kmike kmike commented Feb 28, 2020

+1 to remove all this. Just to be sure, let's summon @dangra to merge it :)

dangra
dangra approved these changes Mar 4, 2020
@dangra dangra merged commit c57512f into scrapy:master Mar 4, 2020
2 checks passed
@dangra
Copy link
Member

@dangra dangra commented Mar 4, 2020

Scrapinghub deb package have been dead for a long time. Long life to Debian packages

@nyov nyov deleted the nodeb branch Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants