Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a 'twisted.test.proto_helpers' deprecation warning #4409

Merged
merged 1 commit into from Mar 12, 2020

Conversation

nyov
Copy link
Contributor

@nyov nyov commented Mar 7, 2020

No description provided.

@codecov
Copy link

@codecov codecov bot commented Mar 7, 2020

Codecov Report

Merging #4409 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4409      +/-   ##
==========================================
- Coverage   84.56%   84.54%   -0.03%     
==========================================
  Files         166      166              
  Lines        9869     9869              
  Branches     1467     1467              
==========================================
- Hits         8346     8344       -2     
- Misses       1268     1269       +1     
- Partials      255      256       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 89.39% <0.00%> (-1.52%) ⬇️

wRAR
wRAR approved these changes Mar 10, 2020
@kmike kmike merged commit db9198b into scrapy:master Mar 12, 2020
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Mar 12, 2020

Thanks @nyov!

@nyov nyov deleted the remove-deprecation-warning branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants