Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Spider.make_requests_from_url, part 2 #4412

Merged
merged 1 commit into from Mar 12, 2020

Conversation

nyov
Copy link
Contributor

@nyov nyov commented Mar 7, 2020

Follow-up for #1728,
Blocking #4178

@codecov
Copy link

@codecov codecov bot commented Mar 7, 2020

Codecov Report

Merging #4412 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4412   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         166      166           
  Lines        9869     9870    +1     
  Branches     1467     1467           
=======================================
+ Hits         8346     8347    +1     
+ Misses       1268     1267    -1     
- Partials      255      256    +1     
Impacted Files Coverage Δ
scrapy/spiders/__init__.py 100.00% <100.00%> (+1.56%) ⬆️
scrapy/utils/trackref.py 82.85% <0.00%> (-2.86%) ⬇️

scrapy/spiders/__init__.py Outdated Show resolved Hide resolved
@nyov nyov force-pushed the deprecate-req-from-url branch from f562dc7 to 2245ede Compare Mar 10, 2020
kmike
kmike approved these changes Mar 12, 2020
Copy link
Member

@kmike kmike left a comment

👍 Thanks @nyov!

@Gallaecio Gallaecio merged commit 3b0820d into scrapy:master Mar 12, 2020
2 checks passed
@nyov nyov deleted the deprecate-req-from-url branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants