Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore a domain in allowed_domains with port and issue a warning #4413

Merged
merged 2 commits into from Mar 12, 2020

Conversation

Lukas0907
Copy link
Contributor

@Lukas0907 Lukas0907 commented Mar 7, 2020

Fix for issue #50, see discussion there for a rationale.

Note that this PR is based on PR #4410 and would make PR #3198 obsolete.

Fixes #50, closes #3198

Lukas0907 added 2 commits Mar 7, 2020
Nones in allowed_domains ought to be ignored and there are also tests
for that scenario. This commit fixes the handling of None and also the
accompanying tests which are now executed again.
@codecov
Copy link

@codecov codecov bot commented Mar 7, 2020

Codecov Report

Merging #4413 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4413      +/-   ##
==========================================
+ Coverage   84.56%   84.58%   +0.01%     
==========================================
  Files         166      166              
  Lines        9869     9878       +9     
  Branches     1467     1468       +1     
==========================================
+ Hits         8346     8355       +9     
  Misses       1268     1268              
  Partials      255      255              

wRAR
wRAR approved these changes Mar 11, 2020
@Gallaecio Gallaecio merged commit ccc4d88 into scrapy:master Mar 12, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants