Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response.follow_all: return empty generators for empty sequences #4420

Merged
merged 1 commit into from Mar 12, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Mar 12, 2020

Fixes #4408

@wRAR wRAR added this to the 2.0.1 milestone Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #4420 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4420      +/-   ##
==========================================
+ Coverage   84.72%   84.73%   +0.01%     
==========================================
  Files         166      166              
  Lines        9899     9899              
  Branches     1472     1473       +1     
==========================================
+ Hits         8387     8388       +1     
  Misses       1255     1255              
+ Partials      257      256       -1
Impacted Files Coverage Δ
scrapy/http/response/text.py 100% <100%> (ø) ⬆️
scrapy/utils/trackref.py 85.71% <0%> (+2.85%) ⬆️

wRAR
wRAR approved these changes Mar 12, 2020
@kmike kmike merged commit ae5f598 into scrapy:master Mar 12, 2020
2 checks passed
@elacuesta elacuesta deleted the response_follow_all_empty_generator branch Mar 12, 2020
Gallaecio pushed a commit to Gallaecio/scrapy that referenced this pull request Mar 17, 2020
…ty_generator

Response.follow_all: return empty generators for empty sequences
Gallaecio pushed a commit that referenced this pull request Mar 18, 2020
…erator

Response.follow_all: return empty generators for empty sequences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow_all fails with an empty list of URLs
3 participants