Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict pytest to versions prior to 5.4 #4422

Merged
merged 1 commit into from Mar 13, 2020
Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 13, 2020

Let us see if that’s what is breaking the tests.

@codecov
Copy link

@codecov codecov bot commented Mar 13, 2020

Codecov Report

Merging #4422 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4422      +/-   ##
==========================================
+ Coverage   84.72%   84.74%   +0.02%     
==========================================
  Files         166      166              
  Lines        9899     9906       +7     
  Branches     1473     1474       +1     
==========================================
+ Hits         8387     8395       +8     
+ Misses       1255     1254       -1     
  Partials      257      257              
Impacted Files Coverage Δ
scrapy/spidermiddlewares/offsite.py 100.00% <100.00%> (ø)
scrapy/spiders/__init__.py 100.00% <100.00%> (+1.56%) ⬆️

@Gallaecio
Copy link
Member Author

@Gallaecio Gallaecio commented Mar 13, 2020

wRAR
wRAR approved these changes Mar 13, 2020
@wRAR wRAR merged commit 0afe3da into scrapy:master Mar 13, 2020
2 checks passed
@wRAR wRAR added this to the v2.0.1 milestone Mar 13, 2020
Gallaecio pushed a commit to Gallaecio/scrapy that referenced this issue Mar 17, 2020
Restrict pytest to versions prior to 5.4
Gallaecio pushed a commit that referenced this issue Mar 18, 2020
Restrict pytest to versions prior to 5.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants