Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object base class #4430

Merged
merged 7 commits into from Mar 16, 2020
Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Mar 15, 2020

No description provided.

@codecov
Copy link

@codecov codecov bot commented Mar 15, 2020

Codecov Report

Merging #4430 into master will decrease coverage by 0.04%.
The diff coverage is 98.95%.

@@            Coverage Diff             @@
##           master    #4430      +/-   ##
==========================================
- Coverage   84.78%   84.74%   -0.05%     
==========================================
  Files         164      166       +2     
  Lines        9888     9915      +27     
  Branches     1469     1474       +5     
==========================================
+ Hits         8384     8402      +18     
- Misses       1249     1257       +8     
- Partials      255      256       +1
Impacted Files Coverage Δ
scrapy/utils/deprecate.py 95.38% <ø> (ø) ⬆️
scrapy/extensions/statsmailer.py 0% <0%> (ø) ⬆️
scrapy/loader/processors.py 100% <100%> (ø) ⬆️
scrapy/utils/python.py 85.36% <100%> (ø) ⬆️
scrapy/spidermiddlewares/depth.py 100% <100%> (ø) ⬆️
scrapy/dupefilters.py 98.11% <100%> (ø) ⬆️
scrapy/utils/trackref.py 85.71% <100%> (ø) ⬆️
scrapy/core/engine.py 92.88% <100%> (ø) ⬆️
scrapy/extensions/throttle.py 46% <100%> (ø) ⬆️
scrapy/utils/log.py 88.76% <100%> (ø) ⬆️
... and 64 more

wRAR
wRAR approved these changes Mar 16, 2020
@Gallaecio Gallaecio merged commit dfbe1d9 into scrapy:master Mar 16, 2020
1 check was pending
@elacuesta elacuesta deleted the remove-object-base-class branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants