Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ChunkedTransferMiddleware #4431

Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Mar 15, 2020

Deprecated in #2411 (v1.3)

See also #4356

@codecov
Copy link

@codecov codecov bot commented Mar 15, 2020

Codecov Report

Merging #4431 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4431      +/-   ##
==========================================
- Coverage   84.74%   84.58%   -0.16%     
==========================================
  Files         166      165       -1     
  Lines        9915     9905      -10     
  Branches     1474     1473       -1     
==========================================
- Hits         8402     8378      -24     
- Misses       1257     1271      +14     
  Partials      256      256              
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️

wRAR
wRAR approved these changes Mar 16, 2020
@Gallaecio Gallaecio merged commit e571112 into scrapy:master Mar 16, 2020
2 checks passed
@elacuesta elacuesta deleted the remove-chunked-transfer-middleware branch Mar 16, 2020
import warnings

from scrapy.exceptions import ScrapyDeprecationWarning
from scrapy.utils.http import decode_chunked_transfer
Copy link
Member

@kmike kmike Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this function?

Copy link
Member

@kmike kmike Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, it was only deprecated in 1.7. Makes sense to keep it for now.

Copy link
Member Author

@elacuesta elacuesta Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I removed it in an initial version of this branch but then I realized it was deprecated very recently (#3859)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants