Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit zsh completion #4438

Merged
merged 1 commit into from Mar 20, 2020
Merged

edit zsh completion #4438

merged 1 commit into from Mar 20, 2020

Conversation

matsievskiysv
Copy link
Contributor

@matsievskiysv matsievskiysv commented Mar 17, 2020

  • Fix bug introduced in add zsh -h autocomplete option #4291
  • Enforce [command] [options] [arguments] syntax. Do not allow options after arguments
  • Exclude already used option aliases from completion list

- Fix bug introduced in scrapy#4291
- Enforce `[command] [options] [arguments]` syntax. Do not allow options after arguments
- Exclude already used option aliases from completion list
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #4438 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4438   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         164      164           
  Lines        9883     9883           
  Branches     1469     1469           
=======================================
  Hits         8379     8379           
  Misses       1248     1248           
  Partials      256      256           

@kmike kmike merged commit c26308d into scrapy:master Mar 20, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Mar 20, 2020

Thanks @seregaxvm! Merging it without checking how it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants