Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update redirect links to python3 #4445

Merged
merged 4 commits into from Apr 15, 2020
Merged

Conversation

adityaa30
Copy link
Contributor

@adityaa30 adityaa30 commented Mar 20, 2020

Fixes #4444

Copy link
Member

@Gallaecio Gallaecio left a comment

I’ve not reviewed the whole changeset, but I think my 2 last comments may help you figure out how to use InterSphinx in some other cases where you simply updated the URL.

docs/topics/downloader-middleware.rst Outdated Show resolved Hide resolved
docs/topics/exporters.rst Outdated Show resolved Hide resolved
docs/topics/exporters.rst Outdated Show resolved Hide resolved
docs/topics/items.rst Outdated Show resolved Hide resolved
docs/topics/items.rst Outdated Show resolved Hide resolved
docs/topics/items.rst Outdated Show resolved Hide resolved
docs/topics/logging.rst Outdated Show resolved Hide resolved
docs/topics/logging.rst Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Mar 24, 2020

Codecov Report

Merging #4445 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4445      +/-   ##
=========================================
- Coverage   84.79%   84.6%   -0.19%     
=========================================
  Files         164     164              
  Lines        9883    9889       +6     
  Branches     1469    1469              
=========================================
- Hits         8380    8367      -13     
- Misses       1248    1266      +18     
- Partials      255     256       +1
Impacted Files Coverage Δ
scrapy/item.py 98.57% <ø> (ø) ⬆️
scrapy/robotstxt.py 75.3% <0%> (-22.23%) ⬇️
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️
scrapy/crawler.py 89.32% <0%> (+0.37%) ⬆️

@adityaa30
Copy link
Contributor Author

@adityaa30 adityaa30 commented Mar 24, 2020

@Gallaecio Thanks a lot for you review. I have done the requested changes and also refactored the links following the pattern https://docs.python.org/3/* with their respective intersphinx python inventory's target.

Copy link
Member

@Gallaecio Gallaecio left a comment

Mind that the python: prefix is only necessary for disambiguation, so it should not be necessary in most cases. Feel free to leave it, it does not hurt, but know that it is not needed.

docs/intro/tutorial.rst Outdated Show resolved Hide resolved
Copy link
Member

@Gallaecio Gallaecio left a comment

Nice, I had no idea we could avoid mod that way!

There is only a couple of additional cases to fix, but I think that’s it 🙂

On a different topic: once your code is reviewed once, further updates are better done without force-pushing, and instead using regular merges and such, so that we can review the changes to your previous changes, instead of having to review the whole patch again just in case. We can squash your commits when we merge into master, so keeping a clean commit history should not be that much of a problem.

docs/topics/request-response.rst Outdated Show resolved Hide resolved
@adityaa30
Copy link
Contributor Author

@adityaa30 adityaa30 commented Mar 26, 2020

On a different topic: once your code is reviewed once, further updates are better done without force-pushing, and instead using regular merges and such, so that we can review the changes to your previous changes, instead of having to review the whole patch again just in case. We can squash your commits when we merge into master, so keeping a clean commit history should not be that much of a problem.

@Gallaecio Sure. Thanks a lot for mentioning and your review!
I have done the requested changes.

@adityaa30 adityaa30 changed the title [docs] update redirect links to python3 [MRG] update redirect links to python3 Apr 2, 2020
@kmike kmike merged commit 36abe92 into scrapy:master Apr 15, 2020
1 check was pending
@kmike
Copy link
Member

@kmike kmike commented Apr 15, 2020

Nice cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants