This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS: That is now the only test failing in Python 3.7.
The failing assertions are about looking for ConnectionRefusedError/ConnectError with the alternative resolver. I ran a debug pipeline (I don't have access to a Windows machine) and it seems to me like it fails because of the assumption that there is no web server listening on the local host. Apparently there is something in the test environment indeed listening on http://[::1] so the test fails because the connection is not refused.
I think the test should not care about the presence of ConnectionRefusedError exceptions but about the absence of DNSLookupError, I can fix that 👍
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.