Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pycodestyle E2XX (whitespace) #4468

Merged
merged 7 commits into from Apr 15, 2020
Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Apr 1, 2020

Most of the changes are to test files.

This PR deals with E2XX errors exclusively: for instance, the changed lines in tests/test_webclient.py are still affected by E122 ("continuation line missing indentation or outdented")

Some of the above changes conflict with #4392 (please take alook @noviluni)

@codecov
Copy link

@codecov codecov bot commented Apr 1, 2020

Codecov Report

Merging #4468 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4468      +/-   ##
==========================================
+ Coverage   84.75%   84.79%   +0.04%     
==========================================
  Files         164      164              
  Lines        9889     9889              
  Branches     1469     1469              
==========================================
+ Hits         8381     8385       +4     
+ Misses       1250     1248       -2     
+ Partials      258      256       -2
Impacted Files Coverage Δ
scrapy/pipelines/media.py 97.29% <ø> (ø) ⬆️
scrapy/pipelines/images.py 90.65% <ø> (ø) ⬆️
scrapy/pipelines/files.py 61.66% <ø> (ø) ⬆️
scrapy/core/downloader/tls.py 86.04% <ø> (ø) ⬆️
scrapy/dupefilters.py 98.11% <100%> (ø) ⬆️
scrapy/utils/misc.py 97.11% <0%> (+1.92%) ⬆️
scrapy/utils/defer.py 95.65% <0%> (+2.17%) ⬆️

tests/test_crawl.py Outdated Show resolved Hide resolved
wRAR
wRAR approved these changes Apr 6, 2020
@elacuesta elacuesta closed this Apr 6, 2020
@elacuesta elacuesta reopened this Apr 6, 2020
@Gallaecio Gallaecio merged commit 94d7ad7 into scrapy:master Apr 15, 2020
1 check failed
@elacuesta elacuesta deleted the fix-pycodestyle-e2xx branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants