Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty _RequestBodyProducer for POST requests #4472

Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Apr 5, 2020

We are already requiring Twisted>17. Relevant tests here.

@codecov
Copy link

@codecov codecov bot commented Apr 5, 2020

Codecov Report

Merging #4472 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4472      +/-   ##
==========================================
+ Coverage   84.75%   84.79%   +0.04%     
==========================================
  Files         164      164              
  Lines        9889     9887       -2     
  Branches     1469     1468       -1     
==========================================
+ Hits         8381     8384       +3     
+ Misses       1250     1248       -2     
+ Partials      258      255       -3     
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 92.91% <ø> (-0.06%) ⬇️
scrapy/utils/misc.py 97.11% <0.00%> (+1.92%) ⬆️
scrapy/utils/defer.py 95.65% <0.00%> (+2.17%) ⬆️
scrapy/utils/trackref.py 85.71% <0.00%> (+2.85%) ⬆️

wRAR
wRAR approved these changes Apr 6, 2020
@wRAR wRAR merged commit 49357cc into scrapy:master Apr 6, 2020
2 checks passed
@elacuesta elacuesta deleted the remove-request-body-producer-empty-body branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants