This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the changes to log warnings whenever something that was ported is used.
Not sure if that's the best approach, so fell free to raise any concerns about it.
Also, updated the documentation removing most of the content.
The idea is to include a link to itemloaders library docs once it is up and running.
Regarding the docs, not sure if we should keep some sort of TOC pointing to stuff that was moved from scrapy..
@Gallaecio , I've updated the PR with your ideas.
Just bear in mind in that, extract_regex was already in parsel.utils, so I just added a simple test in test_loader_deprecated so we don't need a new file only for this case.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.