Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8: remove W504 code #4525

Merged
merged 3 commits into from May 5, 2020
Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Apr 29, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #4525 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4525   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         164      164           
  Lines        9897     9898    +1     
  Branches     1480     1480           
=======================================
+ Hits         8368     8369    +1     
  Misses       1261     1261           
  Partials      268      268           
Impacted Files Coverage Δ
scrapy/contracts/__init__.py 83.46% <100.00%> (+0.13%) ⬆️
scrapy/downloadermiddlewares/redirect.py 97.01% <100.00%> (ø)
scrapy/extensions/telnet.py 81.66% <100.00%> (ø)
scrapy/linkextractors/__init__.py 97.10% <100.00%> (ø)
scrapy/spidermiddlewares/referer.py 93.00% <100.00%> (ø)
scrapy/utils/gz.py 96.87% <100.00%> (ø)

wRAR
wRAR approved these changes Apr 29, 2020
scrapy/contracts/__init__.py Outdated Show resolved Hide resolved
elacuesta and others added 2 commits Apr 29, 2020
Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>
kmike
kmike approved these changes May 4, 2020
Copy link
Member

@kmike kmike left a comment

Thanks @elacuesta!
@Gallaecio please make a final decision, on when we merge it :)

@Gallaecio Gallaecio merged commit 17c0cf6 into scrapy:master May 5, 2020
2 checks passed
@elacuesta elacuesta deleted the remove-w504-flake8-code branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants