Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8: remove E123 #4540

Merged
merged 4 commits into from May 6, 2020
Merged

Flake8: remove E123 #4540

merged 4 commits into from May 6, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented May 6, 2020

Closing bracket does not match indentation of opening bracket's line

Based on #4539, which is in turn based on #4538, to avoid merge conflicts.

Relevant changes in 8643e8d

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4540 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
- Coverage   84.55%   84.48%   -0.07%     
==========================================
  Files         164      164              
  Lines        9898     9903       +5     
  Branches     1480     1481       +1     
==========================================
- Hits         8369     8367       -2     
- Misses       1261     1267       +6     
- Partials      268      269       +1     
Impacted Files Coverage Δ
scrapy/extensions/closespider.py 95.12% <ø> (ø)
scrapy/core/downloader/handlers/ftp.py 98.36% <100.00%> (ø)
scrapy/core/engine.py 87.87% <100.00%> (ø)
scrapy/http/request/form.py 95.34% <100.00%> (ø)
scrapy/pipelines/media.py 97.29% <100.00%> (ø)
scrapy/utils/deprecate.py 95.38% <100.00%> (ø)
scrapy/utils/request.py 100.00% <100.00%> (ø)
scrapy/core/downloader/__init__.py 89.47% <0.00%> (-1.51%) ⬇️
scrapy/pipelines/files.py 59.93% <0.00%> (-1.00%) ⬇️

wRAR
wRAR approved these changes May 6, 2020
@wRAR wRAR merged commit b76d280 into scrapy:master May 6, 2020
2 checks passed
@elacuesta elacuesta deleted the flake8-remove-e123 branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants