Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8: remove E122 and E124 #4542

merged 2 commits into from May 7, 2020


Copy link

@elacuesta elacuesta commented May 6, 2020

  • Continuation line missing indentation or outdented (E122)
  • Closing bracket does not match visual indentation (E124)

Copy link

Gallaecio commented May 6, 2020

I would expect the XML test to fail, given the new code adds extra spaces. We should either ignore the corresponding Flake8 check or use something to remove the spaces from the string.

Copy link
Member Author

elacuesta commented May 6, 2020

I found that those tests look for the document structure, they failed if I altered the name of some tag. XmlItemExporterTest.assertExportResult calls XmlItemExporterTest.assertXmlEquivalent

@elacuesta elacuesta mentioned this pull request May 6, 2020
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4542 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4542   +/-   ##
  Coverage   84.50%   84.50%           
  Files         164      164           
  Lines        9903     9903           
  Branches     1481     1481           
  Hits         8369     8369           
  Misses       1266     1266           
  Partials      268      268           

@elacuesta elacuesta mentioned this pull request May 6, 2020
@kmike kmike merged commit a18bfcc into scrapy:master May 7, 2020
2 checks passed
@elacuesta elacuesta deleted the flake8-remove-e122-e124 branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants