Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8: Remove E128 #4545

Merged
merged 15 commits into from May 14, 2020
Merged

Flake8: Remove E128 #4545

merged 15 commits into from May 14, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented May 6, 2020

Continuation line under-indented for visual indent

Such a big PR for only one code, sorry 馃槗

Based on #4543 to avoid merge conflicts merged

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4545 into master will decrease coverage by 0.00%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #4545      +/-   ##
==========================================
- Coverage   84.55%   84.55%   -0.01%     
==========================================
  Files         164      164              
  Lines        9922     9923       +1     
  Branches     1475     1475              
==========================================
  Hits         8390     8390              
  Misses       1266     1266              
- Partials      266      267       +1     
Impacted Files Coverage 螖
scrapy/commands/__init__.py 61.11% <酶> (酶)
scrapy/commands/genspider.py 83.72% <酶> (酶)
scrapy/commands/parse.py 20.21% <酶> (酶)
scrapy/commands/settings.py 71.87% <酶> (酶)
scrapy/commands/version.py 100.00% <酶> (酶)
scrapy/mail.py 73.75% <50.00%> (酶)
scrapy/commands/fetch.py 89.13% <100.00%> (酶)
scrapy/commands/shell.py 92.85% <100.00%> (酶)
scrapy/commands/startproject.py 100.00% <100.00%> (酶)
scrapy/core/downloader/contextfactory.py 96.66% <100.00%> (酶)
... and 11 more

@elacuesta elacuesta marked this pull request as ready for review May 6, 2020
@wRAR
Copy link
Contributor

wRAR commented May 13, 2020

@elacuesta there are conflicts here as well

wRAR
wRAR approved these changes May 14, 2020
@elacuesta elacuesta merged commit 3d58e5e into scrapy:master May 14, 2020
2 checks passed
@elacuesta elacuesta deleted the flake8-remove-e128 branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants