Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 encoding header from files #4553

merged 1 commit into from May 8, 2020

Remove Python 2 encoding header from files #4553

merged 1 commit into from May 8, 2020


Copy link

@antonio-gor antonio-gor commented May 7, 2020

-- coding: utf-8 -- no longer needed.

(edit) fixes #4550

Copy link
Contributor Author

Need to link issue #4550

Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #4553 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4553   +/-   ##
  Coverage   84.51%   84.51%           
  Files         164      164           
  Lines        9904     9904           
  Branches     1482     1482           
  Hits         8370     8370           
  Misses       1266     1266           
  Partials      268      268           
Impacted Files Coverage Δ
scrapy/downloadermiddlewares/ 95.00% <ø> (ø)
scrapy/ 100.00% <ø> (ø)
scrapy/utils/ 88.76% <ø> (ø)
scrapy/utils/ 53.65% <ø> (ø)

Copy link

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@Gallaecio Gallaecio merged commit cf09af7 into scrapy:master May 8, 2020
2 checks passed
@antonio-gor antonio-gor deleted the 4550 branch May 8, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Remove # -*- coding: utf-8 -*-
3 participants