Flake8: remove E111, E114, E116, E117, E121 #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elacuesta
commented
May 8, 2020
elacuesta
commented
- E111: indentation is not a multiple of four
- E114: indentation is not a multiple of four (comment) - unused
- E116: unexpected indentation (comment)
- E117: over-indented - unused
- E121: continuation line under-indented for hanging indent
elacuesta
commented
May 8, 2020
| if not(response is None or text is None): | ||
| raise ValueError('%s.__init__() received both response and text' | ||
| % self.__class__.__name__) | ||
| if response is not None and text is not None: |
There was a problem hiding this comment.
This is more readable IMHO. De Morgan to the rescue!
Codecov Report
@@ Coverage Diff @@
## master #4557 +/- ##
==========================================
- Coverage 84.51% 84.49% -0.03%
==========================================
Files 164 164
Lines 9904 9904
Branches 1482 1482
==========================================
- Hits 8370 8368 -2
- Misses 1266 1267 +1
- Partials 268 269 +1
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.