New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop response download from signal handler #4559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4559 +/- ##
==========================================
+ Coverage 84.56% 84.62% +0.05%
==========================================
Files 164 164
Lines 9931 9948 +17
Branches 1477 1480 +3
==========================================
+ Hits 8398 8418 +20
+ Misses 1266 1265 -1
+ Partials 267 265 -2
|
kmike
reviewed
May 12, 2020
kmike
reviewed
May 12, 2020
elacuesta
reviewed
May 14, 2020
b480874
to
dc590fe
Compare
kmike
reviewed
May 16, 2020
kmike
reviewed
May 19, 2020
kmike
reviewed
May 19, 2020
kmike
reviewed
May 19, 2020
kmike
reviewed
May 19, 2020
kmike
reviewed
May 19, 2020
kmike
reviewed
May 19, 2020
kmike
reviewed
May 19, 2020
kmike
reviewed
May 19, 2020
f6e7a22
to
276721a
Compare
kmike
reviewed
May 20, 2020
kmike
reviewed
May 26, 2020
Thanks @elacuesta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Allow the cancellation of a download while it's in progress.
Motivated by #4205 (comment).
Tasks:
bytes_received
signal docs