Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary update when value is None #4564

Merged
merged 2 commits into from Aug 10, 2020
Merged

Unnecessary update when value is None #4564

merged 2 commits into from Aug 10, 2020

Conversation

jacty
Copy link
Contributor

@jacty jacty commented May 11, 2020

When value is None, it is not necessary to invoke update and run other methods and conditions to make the code complicated there.

When value is None, it is not necessary to invoke update and run other methods and conditions to make the code complicated there.
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #4564 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4564   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         164      164           
  Lines        9908     9909    +1     
  Branches     1475     1476    +1     
=======================================
+ Hits         8376     8377    +1     
  Misses       1266     1266           
  Partials      266      266           
Impacted Files Coverage Δ
scrapy/settings/__init__.py 92.98% <100.00%> (+0.04%) ⬆️

scrapy/settings/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jacty jacty left a comment

updated as we discussed.

wRAR
wRAR approved these changes Aug 10, 2020
@wRAR wRAR merged commit 702de04 into scrapy:master Aug 10, 2020
1 check failed
@wRAR
Copy link
Contributor

wRAR commented Aug 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants