Flake8: remove E306 and F523 #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4572 +/- ##
=======================================
Coverage 84.55% 84.55%
=======================================
Files 164 164
Lines 9923 9923
Branches 1476 1476
=======================================
Hits 8390 8390
Misses 1266 1266
Partials 267 267 |
|
Hey @noviluni, great work on the upstream fix, thank you very much! |
Merged
|
sure! |
noviluni
force-pushed
the
add_missed_flake8_rules
branch
from
06205e9
to
8971878
Compare
|
Hi @elacuesta, could you take a look? Is this what you requested? |
elacuesta
reviewed
May 13, 2020
| @@ -19,7 +19,7 @@ def _isiterable(possible_iterator): | |||
|
|
|||
|
|
|||
| def _fname(f): | |||
| return "%s.%s".format( | |||
There was a problem hiding this comment.
I'm guilty of this one, until now I hadn't even realized about its oddity.
elacuesta
approved these changes
May 13, 2020
elacuesta
changed the title
|
Travis is failing with 429, perhaps we are triggering too many builds? |
wRAR
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It seems that the last released version of
pytest-flake8fixes the issue causing the Travis pipeline to fail. However, I've seen that it's raising some new cases.