Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded escape sequence #4596

merged 1 commit into from Jun 1, 2020


Copy link

@sharmarohit sharmarohit commented May 24, 2020

removed unneeded escape sequences from method arguments in the docs

Fixes #4592

removed uneeded wscape sequences from method arguments in the docs
Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #4596 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4596   +/-   ##
  Coverage   84.57%   84.57%           
  Files         164      164           
  Lines        9931     9931           
  Branches     1477     1477           
  Hits         8399     8399           
  Misses       1266     1266           
  Partials      266      266           

Copy link

@elacuesta elacuesta left a comment

Looks good, thanks! 👌

I wonder how the changes to docs/topics/loaders.rst affect #4516 though, perhaps we should wait until that's merged.

Copy link

@Gallaecio Gallaecio left a comment

Given how easy it would be to solve conflicts with these changes, I’m OK with merging already.

@kmike kmike merged commit 1d2b692 into scrapy:master Jun 1, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

5 participants