Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --data-raw to utils.curl and fix missing method with data #4612

Merged
merged 2 commits into from Jun 29, 2020

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Jun 3, 2020

When copying a cURL command from the browser I got the --data-raw parameter.

After reading this:

I think we can safely add it as a synonym of --data.

On the other side, this also fixes when missing the method but specifying the data (body), as the method should be interpreted by default as POST.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #4612 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4612   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         163      163           
  Lines        9987     9990    +3     
  Branches     1487     1488    +1     
=======================================
+ Hits         8470     8473    +3     
  Misses       1254     1254           
  Partials      263      263           
Impacted Files Coverage Δ
scrapy/utils/curl.py 100.00% <100.00%> (ø)

wRAR
wRAR approved these changes Jun 4, 2020
scrapy/utils/curl.py Outdated Show resolved Hide resolved
@noviluni noviluni force-pushed the add_data_raw_to_utils_curl branch 2 times, most recently from c2f7109 to 25784bd Compare Jun 25, 2020
@noviluni noviluni force-pushed the add_data_raw_to_utils_curl branch from 25784bd to ace2869 Compare Jun 25, 2020
@noviluni noviluni requested a review from Gallaecio Jun 25, 2020
@Gallaecio Gallaecio merged commit 464f24f into scrapy:master Jun 29, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants