Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4561 - Update genspider.py #4616

Closed
wants to merge 1 commit into from
Closed

#4561 - Update genspider.py #4616

wants to merge 1 commit into from

Conversation

3Dook
Copy link

@3Dook 3Dook commented Jun 8, 2020

Potential Issue #4561 enhancement fix. The bug/glitch occurs when genspider is called outside of a startproject. I added a small and simple check to compare the new spider names to the current files in the directory. If there is already a spider with the file name it will return and stop the function.

Issue scrapy#4561 enhancement. The bug occurs when genspider is called outside of a startproject. I added a small and simple check to compare the new spider names to the current files in the directory. If there is already a spider with the file name it will return and stop the function.
@wRAR
Copy link
Contributor

wRAR commented Jun 8, 2020

Can't you check if the file exists directly?

@wRAR
Copy link
Contributor

wRAR commented Jul 15, 2021

Fixed in #4623.

@wRAR wRAR closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants