Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update docs on accessing callback arguments in errback #4634

Merged
merged 6 commits into from Jun 18, 2020
Merged

DOC: Update docs on accessing callback arguments in errback #4634

merged 6 commits into from Jun 18, 2020

Conversation

dsandeep0138
Copy link
Contributor

Update docs with the info on accessing callback arguments
(cb_kwargs) in errback. Also, included an example for the same.

Fixes #4598

Update docs with the info on accessing callback arguments
(cb_kwargs) in errback. Also, included an example for the
same.
Update docs with the info on accessing callback arguments
(cb_kwargs) in errback. Also, included an example for the
same.
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #4634 into master will increase coverage by 0.03%.
The diff coverage is 91.25%.

@@            Coverage Diff             @@
##           master    #4634      +/-   ##
==========================================
+ Coverage   84.76%   84.80%   +0.03%     
==========================================
  Files         163      163              
  Lines        9978     9987       +9     
  Branches     1489     1487       -2     
==========================================
+ Hits         8458     8469      +11     
  Misses       1254     1254              
+ Partials      266      264       -2     
Impacted Files Coverage Δ
scrapy/spiders/feed.py 66.15% <ø> (ø)
scrapy/commands/parse.py 20.21% <33.33%> (ø)
scrapy/contracts/default.py 84.61% <80.00%> (+0.30%) ⬆️
scrapy/core/scraper.py 87.97% <80.00%> (ø)
scrapy/shell.py 67.96% <80.00%> (-0.25%) ⬇️
scrapy/exporters.py 100.00% <100.00%> (ø)
scrapy/item.py 98.73% <100.00%> (ø)
scrapy/loader/__init__.py 95.54% <100.00%> (-0.03%) ⬇️
scrapy/pipelines/files.py 60.64% <100.00%> (+0.71%) ⬆️
scrapy/pipelines/images.py 91.81% <100.00%> (+1.16%) ⬆️
... and 2 more

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for going the extra mile and creating a section with an example, it’s really appreciated!

docs/topics/request-response.rst Outdated Show resolved Hide resolved
docs/topics/request-response.rst Outdated Show resolved Hide resolved
docs/topics/request-response.rst Outdated Show resolved Hide resolved
Co-authored-by: Eugenio Lacuesta <1731933+elacuesta@users.noreply.github.com>
Copy link
Member

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsandeep0138
Copy link
Contributor Author

Thanks @Gallaecio and @elacuesta for the review!

docs/topics/request-response.rst Outdated Show resolved Hide resolved
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@Gallaecio Gallaecio merged commit 5d54173 into scrapy:master Jun 18, 2020
1 check was pending
@dsandeep0138 dsandeep0138 deleted the issue#4598 branch July 19, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eb_kwargs for errback
3 participants