Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing: Tox env, CI job #4637

Merged
merged 1 commit into from Jun 23, 2020
Merged

Typing: Tox env, CI job #4637

merged 1 commit into from Jun 23, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jun 18, 2020

As discussed recently, here's a PR that contains only the Tox/CI changes, not any specific type annotations.

See also #4243.

[testenv:typing]
basepython = python3
deps =
mypy==0.780
Copy link
Member Author

@elacuesta elacuesta Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, last version is 0.781, but 0.780 is the last one to have an actual release post so I thought it might be safer.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #4637 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4637   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         163      163           
  Lines        9987     9987           
  Branches     1487     1487           
=======================================
  Hits         8469     8469           
  Misses       1254     1254           
  Partials      264      264           

wRAR
wRAR approved these changes Jun 19, 2020
@wRAR wRAR merged commit 4bee73c into scrapy:master Jun 23, 2020
2 checks passed
@elacuesta elacuesta deleted the typing branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants