Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add note about dataclass items and loaders #4642

Merged
merged 3 commits into from Jun 23, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jun 22, 2020

I only commented this as part of the description of #3881, but it should be documented in the actual docs.

@elacuesta elacuesta added the docs label Jun 22, 2020
@elacuesta elacuesta added this to the v2.2 milestone Jun 22, 2020
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #4642 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4642   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         163      163           
  Lines        9987     9987           
  Branches     1487     1487           
=======================================
  Hits         8469     8469           
  Misses       1254     1254           
  Partials      264      264           

docs/topics/loaders.rst Outdated Show resolved Hide resolved
docs/topics/loaders.rst Outdated Show resolved Hide resolved
elacuesta and others added 2 commits Jun 22, 2020
wRAR
wRAR approved these changes Jun 23, 2020
@wRAR wRAR merged commit 374d996 into scrapy:master Jun 23, 2020
2 checks passed
@elacuesta elacuesta deleted the docs-loaders-dataclass branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants