Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spider constructor expects name as argument, not start_urls. #4645

Merged
merged 1 commit into from Jun 25, 2020

Conversation

Lukas0907
Copy link
Contributor

@Lukas0907 Lukas0907 commented Jun 23, 2020

Fixes #4644

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #4645 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4645      +/-   ##
==========================================
+ Coverage   84.78%   84.80%   +0.02%     
==========================================
  Files         163      163              
  Lines        9987     9987              
  Branches     1487     1487              
==========================================
+ Hits         8467     8469       +2     
  Misses       1255     1255              
+ Partials      265      263       -2     
Impacted Files Coverage Δ
scrapy/core/engine.py 87.44% <0.00%> (-0.44%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (+1.50%) ⬆️
scrapy/utils/trackref.py 85.71% <0.00%> (+2.85%) ⬆️

wRAR
wRAR approved these changes Jun 23, 2020
@wRAR
Copy link
Contributor

wRAR commented Jun 23, 2020

Nice catch!

@Gallaecio Gallaecio added this to the v2.3 milestone Jun 24, 2020
@kmike kmike merged commit 0c8d8c5 into scrapy:master Jun 25, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_integration_downloader_aware_priority_queue raises exception
5 participants