Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to item-pipeline documentation explaining order #465

Merged
merged 2 commits into from Nov 20, 2013

Conversation

@bjlange
Copy link
Contributor

@bjlange bjlange commented Nov 19, 2013

As a new Scrapy user I had trouble hunting down what the numbers meant in the ITEM_PIPELINES setting. I added a note to the item-pipeline documentation to make it more clear.

@kmike
Copy link
Member

@kmike kmike commented Nov 19, 2013

Hi @bjlange,

Good catch. But it is still unclear if these numbers mean "order" (pipelines with large numbers are applied last) or "priority" (pipelines with large numbers are applied first)

@bjlange
Copy link
Contributor Author

@bjlange bjlange commented Nov 19, 2013

Good call. I made a revision.

For anyone curious who finds this PR in the future, the source code that makes it work this way is located here as of posting.

@dangra
Copy link
Member

@dangra dangra commented Nov 20, 2013

LGTM

kmike added a commit that referenced this pull request Nov 20, 2013
Add note to item-pipeline documentation explaining order
@kmike kmike merged commit 8416cc7 into scrapy:master Nov 20, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@kmike
Copy link
Member

@kmike kmike commented Nov 20, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.