Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew localhost certificate #4650

Merged
merged 1 commit into from Jun 29, 2020
Merged

Conversation

adityaa30
Copy link
Contributor

@adityaa30 adityaa30 commented Jun 28, 2020

Previous certificate were expired which makes tests in #4610 fail with OpenSSL.SSL.Error.

[Failure instance: Traceback: <class 'OpenSSL.SSL.Error'>: [('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')]

Updated the certificates with
Validity

  • Not Before: Jun 28 12:54:15 2020 GMT
  • Not After : Jun 28 12:54:15 2021 GMT

Subject: C = IE, O = Scrapy, CN = localhost

Validity
  Not Before: Jun 28 12:54:15 2020 GMT
  Not After : Jun 28 12:54:15 2021 GMT
Subject: C = IE, O = Scrapy, CN = localhost
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #4650 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4650      +/-   ##
==========================================
- Coverage   84.80%   84.78%   -0.03%     
==========================================
  Files         163      163              
  Lines        9987     9987              
  Branches     1487     1487              
==========================================
- Hits         8469     8467       -2     
- Misses       1255     1257       +2     
  Partials      263      263              
Impacted Files Coverage Δ
scrapy/crawler.py 87.15% <0.00%> (-1.12%) ⬇️

wRAR
wRAR approved these changes Jun 29, 2020
@Gallaecio Gallaecio merged commit e46b47c into scrapy:master Jun 29, 2020
2 checks passed
@adityaa30 adityaa30 deleted the renew-certificate branch Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants