Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Simplify dataclass example in item loader page #4652

Merged
merged 1 commit into from Jul 1, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jun 30, 2020

@ejulio's example here made me realize the example from #4642 is needlessly complicated.

Perhaps #4516 gets merged first, but it probably doesn't hurt to merge this one too.

@elacuesta elacuesta added the docs label Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #4652 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4652      +/-   ##
==========================================
- Coverage   84.79%   84.68%   -0.12%     
==========================================
  Files         163      163              
  Lines        9990     9990              
  Branches     1488     1488              
==========================================
- Hits         8471     8460      -11     
- Misses       1255     1265      +10     
- Partials      264      265       +1     
Impacted Files Coverage Δ
scrapy/utils/py36.py 20.00% <0.00%> (-80.00%) ⬇️
scrapy/utils/spider.py 66.66% <0.00%> (-11.12%) ⬇️
scrapy/core/downloader/__init__.py 89.47% <0.00%> (-1.51%) ⬇️
scrapy/crawler.py 87.15% <0.00%> (-1.12%) ⬇️
scrapy/utils/trackref.py 85.71% <0.00%> (+2.85%) ⬆️

wRAR
wRAR approved these changes Jul 1, 2020
@wRAR wRAR merged commit 0379df8 into scrapy:master Jul 1, 2020
2 checks passed
@elacuesta elacuesta deleted the docs-loaders-dataclass branch Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants