Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F strings used #4672

Closed
wants to merge 3 commits into from
Closed

F strings used #4672

wants to merge 3 commits into from

Conversation

ashishrawat0
Copy link

Well, I have changed the use of fstring in some of the places. Please review the PR

I will change the other print commands also if this PR gets Approved

@elacuesta
Copy link
Member

Hey @ashishrawat0, thanks for your work. I don't want to discourage your contribution, but there's already an open PR about this (#4324). It has currently many conflicts, because as mentioned in the original issue (#4307), f-strings need Python 3.6+ and we still support 3.5.

@ashishrawat0
Copy link
Author

Hi, @elacuesta thanks for letting me know I just wanted to know that can we use .format() because python 3.5 supports it and thanks for replying I just wanted to contribute to open-source projects.

@Gallaecio
Copy link
Member

@ashishrawat0 Switching to format now to switch to f-strings in a few months (3.5 reaches end of life soon) seems a bit pointless to me. I think it might be better to close this pull request, and just leave #4324 open for the eventual switch to f-strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants