Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python 2 reminiscence in cookies #4682

Merged
merged 1 commit into from Jul 16, 2020

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Jul 16, 2020

The getheaders method was implemented to be compatible with Python 2, but as we dropped the support for Python 2 we don't need it anymore. It's enough to delete it or do you prefer to add a deprecation warning before doing it?

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #4682 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4682   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         162      162           
  Lines        9718     9717    -1     
  Branches     1438     1438           
=======================================
  Hits         8272     8272           
  Misses       1186     1186           
+ Partials      260      259    -1     
Impacted Files Coverage Δ
scrapy/http/cookies.py 91.45% <ø> (-0.08%) ⬇️
scrapy/utils/trackref.py 85.71% <0.00%> (+2.85%) ⬆️

@kmike
Copy link
Member

kmike commented Jul 16, 2020

A good catch @noviluni. I think we don't need a deprecation here, because it is Python stdlib who calls this method, not Scrapy users.

@kmike kmike merged commit 9a74a71 into scrapy:master Jul 16, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants