Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete S3FeedStorage instancing without AWS credentials #4688

Merged
merged 6 commits into from Aug 17, 2020
Merged

Remove obsolete S3FeedStorage instancing without AWS credentials #4688

merged 6 commits into from Aug 17, 2020

Conversation

ashellunts
Copy link
Contributor

@ashellunts ashellunts commented Jul 21, 2020

I have taken this PR #4411 and added fix for a failure in tests (not used import).

I hope @nyov is fine with that.

#4356

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #4688 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4688      +/-   ##
==========================================
- Coverage   86.31%   86.29%   -0.03%     
==========================================
  Files         160      160              
  Lines        9669     9661       -8     
  Branches     1419     1417       -2     
==========================================
- Hits         8346     8337       -9     
- Misses       1062     1063       +1     
  Partials      261      261              
Impacted Files Coverage Δ
scrapy/extensions/feedexport.py 89.72% <ø> (+2.36%) ⬆️
scrapy/utils/py36.py 20.00% <0.00%> (-80.00%) ⬇️
scrapy/utils/spider.py 66.66% <0.00%> (-11.12%) ⬇️

@ashellunts
Copy link
Contributor Author

ashellunts commented Jul 23, 2020

@Gallaecio @wRAR can you review please?

@ashellunts
Copy link
Contributor Author

ashellunts commented Aug 3, 2020

Can this be merged?

@ashellunts
Copy link
Contributor Author

ashellunts commented Aug 15, 2020

Hi @Gallaecio. Can this PR be merged? Or something missing?

@kmike
Copy link
Member

kmike commented Aug 17, 2020

@ashellunts looks good, thanks!

We require +1's from 2 core team members before a merge; @Gallaecio approved it, but another commiter haven't reviewed it until now, that's why it was not merged.

@kmike kmike merged commit 61459de into scrapy:master Aug 17, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants