Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "x-gzip" from Requests' "Accept-Encoding" header #469

Merged
merged 1 commit into from Nov 21, 2013

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Nov 21, 2013

Having "x-gzip" as first encoding in "Accept-Encoding" header seems to cause encoding issues with some (IIS?) web servers (response not compressed, valid but not compressed)

"x-gzip" is not included in "Accept-Encoding" headers sent by latest Chrome or Firefox releases

After discussing with @dangra and @pablohoffman (81fbe8c#commitcomment-4617865) the consensus is to remove it in requests still accepting it in responses

Moving "x-gzip" to the end of the accepted encoding list also works (with the server exhibiting the issue)

@dangra
Copy link
Member

@dangra dangra commented Nov 21, 2013

LGTM

pablohoffman added a commit that referenced this pull request Nov 21, 2013
Remove "x-gzip" from Requests' "Accept-Encoding" header
@pablohoffman pablohoffman merged commit 545f260 into scrapy:master Nov 21, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@redapple redapple deleted the redapple:xgzip branch Nov 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants