Remove "x-gzip" from Requests' "Accept-Encoding" header #469
Conversation
|
LGTM |
pablohoffman
added a commit
that referenced
this pull request
Nov 21, 2013
Remove "x-gzip" from Requests' "Accept-Encoding" header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Having "x-gzip" as first encoding in "Accept-Encoding" header seems to cause encoding issues with some (IIS?) web servers (response not compressed, valid but not compressed)
"x-gzip" is not included in "Accept-Encoding" headers sent by latest Chrome or Firefox releases
After discussing with @dangra and @pablohoffman (81fbe8c#commitcomment-4617865) the consensus is to remove it in requests still accepting it in responses
Moving "x-gzip" to the end of the accepted encoding list also works (with the server exhibiting the issue)