Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monkeypatches module from mypy section in setup.cfg #4690

Merged
merged 1 commit into from Jul 23, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jul 22, 2020

No need to ignore the _monkeypatches module during the typing check, it does not exist any more since #4568

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #4690 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4690      +/-   ##
==========================================
- Coverage   86.29%   86.10%   -0.19%     
==========================================
  Files         160      160              
  Lines        9646     9646              
  Branches     1416     1416              
==========================================
- Hits         8324     8306      -18     
- Misses       1062     1080      +18     
  Partials      260      260              
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️

wRAR
wRAR approved these changes Jul 23, 2020
@kmike kmike merged commit ce0c25f into scrapy:master Jul 23, 2020
2 checks passed
@elacuesta elacuesta deleted the typing-setup-remove-monkeypatches branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants