Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the u prefix from strings #4704

Merged
merged 1 commit into from Jul 30, 2020
Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jul 30, 2020

Subset of #4661

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #4704 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4704      +/-   ##
==========================================
+ Coverage   86.31%   86.32%   +0.01%     
==========================================
  Files         160      160              
  Lines        9669     9669              
  Branches     1419     1419              
==========================================
+ Hits         8346     8347       +1     
  Misses       1062     1062              
+ Partials      261      260       -1     
Impacted Files Coverage Δ
scrapy/logformatter.py 94.59% <ø> (ø)
scrapy/http/request/form.py 95.34% <100.00%> (ø)
scrapy/linkextractors/lxmlhtml.py 95.00% <100.00%> (ø)
scrapy/utils/trackref.py 85.71% <0.00%> (+2.85%) ⬆️

@@ -23,7 +23,7 @@ def main():
_contents = None

# A regex that matches standard linkcheck output lines
line_re = re.compile(u'(.*)\:\d+\:\s\[(.*)\]\s(?:(.*)\sto\s(.*)|(.*))')
line_re = re.compile(r'(.*)\:\d+\:\s\[(.*)\]\s(?:(.*)\sto\s(.*)|(.*))')
Copy link
Member

@kmike kmike Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the non-obvious change in this PR; checked that it is ok:

>>> r'(.*)\:\d+\:\s\[(.*)\]\s(?:(.*)\sto\s(.*)|(.*))' == '(.*)\:\d+\:\s\[(.*)\]\s(?:(.*)\sto\s(.*)|(.*))'
True

@kmike kmike merged commit 015b71d into scrapy:master Jul 30, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Jul 30, 2020

Thanks @Gallaecio!

Gallaecio added a commit to Gallaecio/scrapy that referenced this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants