Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum dependencies for Python 3.6 support #4718

Merged
merged 4 commits into from Aug 17, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 11, 2020

While working on HTTP/2 support, @adityaa30 discovered that simply upgrading the pinned Travis CI job to 3.6 would cause tests to fail.

It turns out we need to first upgrade some pinned dependencies for that to work.

This does so, in preparation for the upcoming removal of Python 3.5 support, but without actually dropping such support yet just in case.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #4718 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4718      +/-   ##
==========================================
+ Coverage   86.69%   86.72%   +0.03%     
==========================================
  Files         160      160              
  Lines        9673     9703      +30     
  Branches     1420     1424       +4     
==========================================
+ Hits         8386     8415      +29     
- Misses       1024     1025       +1     
  Partials      263      263              
Impacted Files Coverage Δ
scrapy/pipelines/media.py 97.16% <0.00%> (-0.14%) ⬇️

@Gallaecio Gallaecio added this to the 2.4 milestone Aug 17, 2020
@kmike kmike merged commit 5ac135f into scrapy:master Aug 17, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Aug 17, 2020

Thanks @Gallaecio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants