Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not let umask affect the permissions of startproject-generated files #4722

Merged
merged 2 commits into from Aug 28, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 12, 2020

This should allow permission tests to pass in Conda Forge builds (see conda-forge/scrapy-feedstock#42).

Includes changes (maxDiff = None, get_permissions) aimed at making test failures more readable.

@Gallaecio Gallaecio added the bug label Aug 12, 2020
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #4722 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4722      +/-   ##
==========================================
+ Coverage   86.70%   86.71%   +0.01%     
==========================================
  Files         160      160              
  Lines        9703     9703              
  Branches     1424     1424              
==========================================
+ Hits         8413     8414       +1     
+ Misses       1026     1025       -1     
  Partials      264      264              
Impacted Files Coverage Δ
scrapy/utils/template.py 100.00% <100.00%> (ø)
scrapy/utils/trackref.py 82.85% <0.00%> (-2.86%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (+1.50%) ⬆️

@kmike kmike requested a review from wRAR Aug 27, 2020
@kmike kmike added this to the 2.4 milestone Aug 27, 2020
wRAR
wRAR approved these changes Aug 28, 2020
@wRAR wRAR merged commit 59a0157 into scrapy:master Aug 28, 2020
2 checks passed
Gallaecio added a commit to conda-forge/scrapy-feedstock that referenced this pull request Feb 23, 2021
Gallaecio added a commit to Gallaecio/scrapy-feedstock that referenced this pull request Feb 23, 2021
Gallaecio added a commit to conda-forge/scrapy-feedstock that referenced this pull request Feb 23, 2021
* Restore tests affected by permission issues

scrapy/scrapy#4722 should have fixed them.

* build += 1

* Imports from failing test_crawler.py prevent permission tests to be run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants