Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_utils_iterators.py: support Windows the right way #4723

Merged
merged 2 commits into from Aug 13, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 13, 2020

It should solve some issues caught by Conda Forge: conda-forge/scrapy-feedstock#44

They were caught by Conda Forge because it uses the test files from the PyPI tarball, not from Git, so in Conda Forge the line endings of files are never changed.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #4723 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4723      +/-   ##
==========================================
- Coverage   86.70%   86.54%   -0.17%     
==========================================
  Files         160      160              
  Lines        9703     9703              
  Branches     1424     1424              
==========================================
- Hits         8413     8397      -16     
- Misses       1026     1043      +17     
+ Partials      264      263       -1     
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (+1.50%) ⬆️

wRAR
wRAR approved these changes Aug 13, 2020
@kmike kmike merged commit 1f44464 into scrapy:master Aug 13, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Aug 13, 2020

TIL git does that. Thanks @Gallaecio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants