Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows pip installation guide #4736

Merged
merged 9 commits into from Apr 1, 2021

Conversation

akshaysharmajs
Copy link
Contributor

Added few steps. Will add all the steps soon.

Fixes #4715

@akshaysharmajs
Copy link
Contributor Author

akshaysharmajs commented Aug 19, 2020

@Gallaecio Is there a need to add screenshots ?

@Gallaecio
Copy link
Member

I would not add screenshots, they are quick to become outdated and hard to update.

docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #4736 into master will increase coverage by 0.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4736      +/-   ##
==========================================
+ Coverage   86.30%   87.21%   +0.91%     
==========================================
  Files         160      160              
  Lines        9672     9813     +141     
  Branches     1419     1447      +28     
==========================================
+ Hits         8347     8558     +211     
+ Misses       1063      994      -69     
+ Partials      262      261       -1     
Impacted Files Coverage Δ
scrapy/core/downloader/webclient.py 94.48% <0.00%> (-3.48%) ⬇️
scrapy/core/scraper.py 87.11% <0.00%> (-0.86%) ⬇️
scrapy/cmdline.py 67.20% <0.00%> (-0.55%) ⬇️
scrapy/utils/defer.py 95.45% <0.00%> (-0.20%) ⬇️
scrapy/pipelines/media.py 97.16% <0.00%> (-0.14%) ⬇️
scrapy/pqueues.py 99.08% <0.00%> (ø)
scrapy/utils/gz.py 96.87% <0.00%> (ø)
scrapy/exporters.py 100.00% <0.00%> (ø)
scrapy/spiderloader.py 100.00% <0.00%> (ø)
scrapy/core/spidermw.py 100.00% <0.00%> (ø)
... and 32 more

docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
akshaysharmajs and others added 2 commits August 26, 2020 19:55
Co-authored-by: Adrián Chaves <adrian@chaves.io>
docs/intro/install.rst Outdated Show resolved Hide resolved
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

docs/intro/install.rst Outdated Show resolved Hide resolved
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@akshaysharmajs
Copy link
Contributor Author

hey @Gallaecio, I was just going through the file install.rst. I think the link to cryptography installation is outdated.

@Gallaecio
Copy link
Member

Indeed. We should probably use InterSphinx to be safer.

Would you create a separate pull request for that, or log an issue about it so that someone else can work on it?

@kmike
Copy link
Member

kmike commented Apr 1, 2021

Thanks @akshaysharmajs and @Gallaecio!

@kmike kmike merged commit cc095aa into scrapy:master Apr 1, 2021
@akshaysharmajs akshaysharmajs deleted the windows-pip-install branch April 3, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Windows installation with pip
3 participants