Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version references after dropping support for 3.5 #4742

Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 20, 2020

Covers everything but:

Resolves #4733

Scrapy requires Python 3.5.2+, either the CPython implementation (default) or
the PyPy 5.9+ implementation (see :ref:`python:implementations`).
Scrapy requires Python 3.6+, either the CPython implementation (default) or
the PyPy 7.2.0+ implementation (see :ref:`python:implementations`).
Copy link
Member Author

@Gallaecio Gallaecio Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PyPy version where 3.6 support went out of beta.

tests/test_proxy_connect.py Outdated Show resolved Hide resolved
@@ -89,7 +89,7 @@ deps =
basepython = python3
deps =
{[pinned]deps}
# First lxml version that includes a Windows wheel for Python 3.5, so we do
# First lxml version that includes a Windows wheel for Python 3.6, so we do
Copy link
Member Author

@Gallaecio Gallaecio Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remains true for 3.6.

scrapy/utils/spider.py Outdated Show resolved Hide resolved
scrapy/utils/py36.py Outdated Show resolved Hide resolved
@Gallaecio Gallaecio closed this Aug 22, 2020
@Gallaecio Gallaecio reopened this Aug 22, 2020
@Gallaecio Gallaecio closed this Aug 25, 2020
@Gallaecio Gallaecio reopened this Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #4742 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #4742   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         160      160           
  Lines        9815     9810    -5     
  Branches     1447     1447           
=======================================
- Hits         8556     8552    -4     
  Misses        996      996           
+ Partials      263      262    -1     
Impacted Files Coverage Δ
scrapy/__init__.py 84.21% <0.00%> (ø)
scrapy/utils/gz.py 96.87% <ø> (ø)
scrapy/utils/defer.py 95.45% <100.00%> (+1.97%) ⬆️
scrapy/core/downloader/__init__.py 89.47% <0.00%> (-1.51%) ⬇️
scrapy/exporters.py 100.00% <0.00%> (ø)
scrapy/utils/misc.py 96.09% <0.00%> (+0.12%) ⬆️
scrapy/utils/reqser.py 94.59% <0.00%> (+1.73%) ⬆️

tests/requirements-py3.txt Outdated Show resolved Hide resolved
scrapy/__init__.py Outdated Show resolved Hide resolved
tests/requirements-py3.txt Outdated Show resolved Hide resolved
@Gallaecio Gallaecio force-pushed the remove-outdated-python-version-references branch from 3e3e18b to 33d5a5a Compare Aug 27, 2020
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
@kmike kmike merged commit 195f738 into scrapy:master Aug 27, 2020
1 of 2 checks passed
@kmike
Copy link
Member

kmike commented Aug 27, 2020

Thanks @Gallaecio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review references to Python 3.5 and 3.6
3 participants