Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iternodes #4746

Merged
merged 8 commits into from Oct 6, 2020
Merged

Fix iternodes #4746

merged 8 commits into from Oct 6, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 21, 2020

This is a continuation of #861.

I’m proposing that we merge the change as is, given it does fix an issue in the current implementation, and then create separate tickets for:

Resolves #861

wRAR
wRAR approved these changes Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #4746 into master will increase coverage by 0.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4746      +/-   ##
==========================================
+ Coverage   87.21%   87.88%   +0.67%     
==========================================
  Files         160      160              
  Lines        9813     9743      -70     
  Branches     1447     1439       -8     
==========================================
+ Hits         8558     8563       +5     
+ Misses        994      923      -71     
+ Partials      261      257       -4     
Impacted Files Coverage Δ
scrapy/utils/iterators.py 97.93% <100.00%> (+0.18%) ⬆️
scrapy/utils/boto.py 43.75% <0.00%> (-27.68%) ⬇️
scrapy/spiders/crawl.py 93.97% <0.00%> (-0.65%) ⬇️
scrapy/link.py 100.00% <0.00%> (ø)
scrapy/downloadermiddlewares/httpproxy.py 100.00% <0.00%> (ø)
scrapy/utils/conf.py 93.75% <0.00%> (+0.05%) ⬆️
scrapy/extensions/feedexport.py 95.22% <0.00%> (+0.20%) ⬆️
scrapy/utils/python.py 87.57% <0.00%> (+1.77%) ⬆️
scrapy/utils/test.py 60.93% <0.00%> (+6.81%) ⬆️
scrapy/pipelines/files.py 71.67% <0.00%> (+11.03%) ⬆️
... and 2 more

@wRAR
Copy link
Contributor

wRAR commented Oct 2, 2020

I'm fine with merging this but there are two instances of %-formatting, should we replace them with f-strings first?

@wRAR wRAR merged commit b1255b0 into scrapy:master Oct 6, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants