Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOWNLOAD_MAXSIZE logger level changed from Error to Warning #4752

Merged
merged 2 commits into from Aug 25, 2020

Conversation

drs-11
Copy link
Contributor

@drs-11 drs-11 commented Aug 24, 2020

Fixes #3874, closes #3886.

Previously @WinterComes tried to solve the issue but hasn't responded to one final query by @kmike.
I completed the simple query.

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #4752 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4752   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         160      160           
  Lines        9815     9815           
  Branches     1447     1447           
=======================================
  Hits         8556     8556           
  Misses        996      996           
  Partials      263      263           
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 93.03% <100.00%> (ø)

@WinterComes
Copy link
Contributor

WinterComes commented Aug 24, 2020

@drs-11 thanks for this

wRAR
wRAR approved these changes Aug 25, 2020
@wRAR wRAR merged commit 067125c into scrapy:master Aug 25, 2020
2 checks passed
@wRAR
Copy link
Contributor

wRAR commented Aug 25, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOWNLOAD_MAXSIZE logger level shouldn't be Error
4 participants